Add option to create new dialog for terraform template in service catalog item #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
|
@putmanoj can you add a screenshot showing the new flow? |
|
(Note we also use the screenshots for the sprint review 😄) |
putmanoj
force-pushed
the
terraform-template-new-dialog
branch
from
24fc97e
to
a7e7e0e
Compare
GilbertCherrie
approved these changes
Oct 8, 2024
|
This pr depends on this pr: ManageIQ/manageiq-providers-embedded_terraform#77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
This PR, make changes for Terraform Template, in New Service Catalog Item page.
Before this PR changes, in Provision tab, the user could not create new dialog for terraform template, they could only select existing service dialogs.
After the changes in PR, in Provision tab, the user can now either choose to use existing service dialog or create new dialog for the terraform template.
If the user chooses to create new dialog, providing new dialog name, then saves the Service Catalog item, new dialog is created in background.
The newly dialog created, will have section added for
Terraform Template Variables, this section will have textboxes for each 'input' variables from terraform template. The newly created dialog can be edited by the user according to needs.In current Hello World example, the terraform template has single input variable called 'name', so you see one textbox component with label 'name'.
When the same Service catalog item is ordered ..